Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(authentication): error during authentication when the environment is secret passed as a liana option and not an environment variable #758

Merged
merged 1 commit into from
Jun 23, 2021

Conversation

ghusse
Copy link
Contributor

@ghusse ghusse commented Jun 23, 2021

Linked to CU-9j1gwn

Pull Request checklist:

  • Write an explicit title for the Pull Request, following Conventional Commits specification
  • Create automatic tests
  • Test manually the implemented changes
  • Review my own code (indentation, syntax, style, simplicity, readability)
  • Wonder if you can improve the existing code

… is secret passed as a liana option and not an environment variable

Linked to CU-9j1gwn
@ghusse ghusse requested a review from Thenkei June 23, 2021 09:24
Copy link
Contributor

@Thenkei Thenkei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🥇

@ghusse ghusse merged commit 39ab674 into master Jun 23, 2021
@ghusse ghusse deleted the fix/env-secret-from-init branch June 23, 2021 09:34
forest-bot added a commit that referenced this pull request Jun 23, 2021
## [7.11.3](v7.11.2...v7.11.3) (2021-06-23)

### Bug Fixes

* **authentication:** error during authentication when the environment is secret passed as a liana option and not an environment variable ([#758](#758)) ([39ab674](39ab674))
@forest-bot
Copy link
Member

🎉 This PR is included in version 7.11.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

forest-bot added a commit that referenced this pull request Jul 6, 2021
# [8.0.0-beta.9](v8.0.0-beta.8...v8.0.0-beta.9) (2021-07-06)

### Bug Fixes

* fix types ([580ef41](580ef41))
* support inverseOf property ([#760](#760)) ([6fab976](6fab976))
* **authentication:** error during authentication when the environment is secret passed as a liana option and not an environment variable ([#758](#758)) ([39ab674](39ab674))
* **intercom:** fix date conversion from unix timestamp to js date of intercom attributes ([#754](#754)) ([11a1549](11a1549))
* **retrocompatibility:** make test suite pass with [email protected] ([#761](#761)) ([a04be5c](a04be5c))
* fix mssql ordering collection by pk ([#734](#734)) ([7bbd19d](7bbd19d))
* prevent IP check from failing for the proxies including the port in the headers ([#751](#751)) ([92852f7](92852f7))

### Features

* add typescript declaration file ([#743](#743)) ([a536f1c](a536f1c))
* include role in the user data inside the request ([#746](#746)) ([425bba5](425bba5))
@forest-bot
Copy link
Member

🎉 This PR is included in version 8.0.0-beta.9 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants